feat(optimzely_fullstack): removed empty values from common payload #2299

Gauravudia · 2023-06-22T05:40:28Z

Description of the change

Optimizely drops the event if empty project id sent in payload (e.g. project_id = ""). Project id is optional parameter.
If empty project id is coming from webapp, removeUndefinedAndNullValues is not removing it from the payload sent to optimizely.
There is one more utility removeUndefinedNullEmptyExclBoolInt that will remove empty values from the payload sent to optimizely.

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

codecov · 2023-06-22T05:46:03Z

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (2f15f90) 86.28% compared to head (cd75f41) 86.26%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2299      +/-   ##
===========================================
- Coverage    86.28%   86.26%   -0.03%     
===========================================
  Files          500      499       -1     
  Lines        25706    25637      -69     
  Branches      6351     6338      -13     
===========================================
- Hits         22181    22116      -65     
+ Misses        3114     3110       -4     
  Partials       411      411

Impacted Files	Coverage Δ
src/cdk/v2/bindings/default.js	`75.00% <100.00%> (+10.71%)`	⬆️
...cdk/v2/destinations/optimizely_fullstack/config.js	`100.00% <100.00%> (ø)`
.../cdk/v2/destinations/optimizely_fullstack/utils.js	`100.00% <100.00%> (ø)`